While updating the click count in the get_link function, the update might fail because the database is locked, due to the poor performances of SQLite.
In case get_link database calls manages to successfully get the link, but fails to update the link count, the error should not be propagated to get_link.
An error should still be displayed in console, but the function must not panic and return 500 Internal Server Error. The database call must return the link without updating the link count.
In case get_link database calls fails to get the link because of a locked database, then the function can return 500.
While updating the click count in the `get_link` function, the update might fail because the database is locked, due to the poor performances of SQLite.
In case `get_link` database calls manages to successfully get the link, but fails to update the link count, the error should not be propagated to `get_link`.
An error should still be displayed in console, but the function must not panic and return 500 Internal Server Error. The database call must return the link without updating the link count.
In case `get_link` database calls **fails** to get the link because of a locked database, then the function can return 500.
Failing to increment a click count for a link will still redirect the user, but without incrementing the link ; though it will display an error messsage in the console
Failing to even get the link will return 500 Internal server error.
Fixed with v2.1.2.
Now:
- Phishing links are not incremented anymore
- Failing to increment a click count for a link will still redirect the user, but without incrementing the link ; though it will display an error messsage in the console
- Failing to even *get* the link will return 500 Internal server error.
While updating the click count in the
get_link
function, the update might fail because the database is locked, due to the poor performances of SQLite.In case
get_link
database calls manages to successfully get the link, but fails to update the link count, the error should not be propagated toget_link
.An error should still be displayed in console, but the function must not panic and return 500 Internal Server Error. The database call must return the link without updating the link count.
In case
get_link
database calls fails to get the link because of a locked database, then the function can return 500.Fixed with v2.1.2.
Now: